feat(keyring): 集成系统密钥环安全存储 API key

This commit is contained in:
2026-03-12 17:42:41 +08:00
parent c66d782eab
commit da85fc94b1
17 changed files with 990 additions and 1024 deletions

View File

@@ -66,6 +66,9 @@ argon2 = "0.5"
rand = "0.8" rand = "0.8"
base64 = "0.22" base64 = "0.22"
# System keyring for secure API key storage
keyring = { version = "3.6.3", features = ["apple-native", "windows-native", "sync-secret-service"] }
# Interactive editor # Interactive editor
edit = "0.1" edit = "0.1"

7
Cargo.toml.test Normal file
View File

@@ -0,0 +1,7 @@
[package]
name = "test-keyring"
version = "0.1.0"
edition = "2024"
[dependencies]
keyring = "3"

View File

@@ -204,12 +204,11 @@ impl ChangelogCommand {
messages: &Messages, messages: &Messages,
) -> Result<String> { ) -> Result<String> {
let manager = ConfigManager::new()?; let manager = ConfigManager::new()?;
let config = manager.config();
let language = manager.get_language().unwrap_or(Language::English); let language = manager.get_language().unwrap_or(Language::English);
println!("{}", messages.ai_generating_changelog()); println!("{}", messages.ai_generating_changelog());
let generator = ContentGenerator::new(&config.llm).await?; let generator = ContentGenerator::new(&manager).await?;
generator.generate_changelog_entry(version, commits, language).await generator.generate_changelog_entry(version, commits, language).await
} }

View File

@@ -257,22 +257,17 @@ impl CommitCommand {
async fn generate_commit(&self, repo: &GitRepo, format: CommitFormat, messages: &Messages) -> Result<String> { async fn generate_commit(&self, repo: &GitRepo, format: CommitFormat, messages: &Messages) -> Result<String> {
let manager = ConfigManager::new()?; let manager = ConfigManager::new()?;
let config = manager.config();
// Check if LLM is configured let generator = ContentGenerator::new(&manager).await
let generator = ContentGenerator::new(&config.llm).await
.context("Failed to initialize LLM. Use --manual for manual commit.")?; .context("Failed to initialize LLM. Use --manual for manual commit.")?;
println!("{}", messages.ai_analyzing()); println!("{}", messages.ai_analyzing());
let language_str = &config.language.output_language; let language = manager.get_language().unwrap_or(Language::English);
let language = Language::from_str(language_str).unwrap_or(Language::English);
let generated = if self.yes { let generated = if self.yes {
// Non-interactive mode: generate directly
generator.generate_commit_from_repo(repo, format, language).await? generator.generate_commit_from_repo(repo, format, language).await?
} else { } else {
// Interactive mode: allow user to review and regenerate
generator.generate_commit_interactive(repo, format, language).await? generator.generate_commit_interactive(repo, format, language).await?
}; };

File diff suppressed because it is too large Load Diff

View File

@@ -8,6 +8,7 @@ use crate::config::{GitProfile, Language};
use crate::config::manager::ConfigManager; use crate::config::manager::ConfigManager;
use crate::config::profile::{GpgConfig, SshConfig}; use crate::config::profile::{GpgConfig, SshConfig};
use crate::i18n::Messages; use crate::i18n::Messages;
use crate::utils::keyring::{get_supported_providers, get_default_model, provider_needs_api_key};
use crate::utils::validators::validate_email; use crate::utils::validators::validate_email;
/// Initialize quicommit configuration /// Initialize quicommit configuration
@@ -31,7 +32,6 @@ impl InitCommand {
crate::config::AppConfig::default_path().unwrap() crate::config::AppConfig::default_path().unwrap()
}); });
// Check if config already exists
if config_path.exists() && !self.reset { if config_path.exists() && !self.reset {
if !self.yes { if !self.yes {
let overwrite = Confirm::new() let overwrite = Confirm::new()
@@ -49,13 +49,11 @@ impl InitCommand {
} }
} }
// Create parent directory if needed
if let Some(parent) = config_path.parent() { if let Some(parent) = config_path.parent() {
std::fs::create_dir_all(parent) std::fs::create_dir_all(parent)
.map_err(|e| anyhow::anyhow!("Failed to create config directory: {}", e))?; .map_err(|e| anyhow::anyhow!("Failed to create config directory: {}", e))?;
} }
// Create new config manager with fresh config
let mut manager = ConfigManager::with_path_fresh(&config_path)?; let mut manager = ConfigManager::with_path_fresh(&config_path)?;
if self.yes { if self.yes {
@@ -66,7 +64,6 @@ impl InitCommand {
manager.save()?; manager.save()?;
// Get configured language for final messages
let language = manager.get_language().unwrap_or(Language::English); let language = manager.get_language().unwrap_or(Language::English);
let messages = Messages::new(language); let messages = Messages::new(language);
@@ -81,7 +78,6 @@ impl InitCommand {
} }
async fn quick_setup(&self, manager: &mut ConfigManager) -> Result<()> { async fn quick_setup(&self, manager: &mut ConfigManager) -> Result<()> {
// Try to get git user info
let git_config = git2::Config::open_default()?; let git_config = git2::Config::open_default()?;
let user_name = git_config.get_string("user.name").unwrap_or_else(|_| "User".to_string()); let user_name = git_config.get_string("user.name").unwrap_or_else(|_| "User".to_string());
@@ -96,7 +92,6 @@ impl InitCommand {
manager.add_profile("default".to_string(), profile)?; manager.add_profile("default".to_string(), profile)?;
manager.set_default_profile(Some("default".to_string()))?; manager.set_default_profile(Some("default".to_string()))?;
// Set default LLM to Ollama
manager.set_llm_provider("ollama".to_string()); manager.set_llm_provider("ollama".to_string());
Ok(()) Ok(())
@@ -106,7 +101,6 @@ impl InitCommand {
let messages = Messages::new(Language::English); let messages = Messages::new(Language::English);
println!("\n{}", messages.setup_profile().bold()); println!("\n{}", messages.setup_profile().bold());
// Language selection
println!("\n{}", messages.select_output_language().bold()); println!("\n{}", messages.select_output_language().bold());
let languages = vec![ let languages = vec![
Language::English, Language::English,
@@ -126,16 +120,13 @@ impl InitCommand {
let selected_language = languages[language_idx]; let selected_language = languages[language_idx];
manager.set_output_language(selected_language.to_code().to_string()); manager.set_output_language(selected_language.to_code().to_string());
// Update messages to selected language
let messages = Messages::new(selected_language); let messages = Messages::new(selected_language);
// Profile name
let profile_name: String = Input::new() let profile_name: String = Input::new()
.with_prompt(messages.profile_name()) .with_prompt(messages.profile_name())
.default("personal".to_string()) .default("personal".to_string())
.interact_text()?; .interact_text()?;
// User info
let git_config = git2::Config::open_default().ok(); let git_config = git2::Config::open_default().ok();
let default_name = git_config.as_ref() let default_name = git_config.as_ref()
@@ -177,7 +168,6 @@ impl InitCommand {
None None
}; };
// SSH configuration
let setup_ssh = Confirm::new() let setup_ssh = Confirm::new()
.with_prompt(messages.configure_ssh()) .with_prompt(messages.configure_ssh())
.default(false) .default(false)
@@ -189,7 +179,6 @@ impl InitCommand {
None None
}; };
// GPG configuration
let setup_gpg = Confirm::new() let setup_gpg = Confirm::new()
.with_prompt(messages.configure_gpg()) .with_prompt(messages.configure_gpg())
.default(false) .default(false)
@@ -201,7 +190,6 @@ impl InitCommand {
None None
}; };
// Create profile
let mut profile = GitProfile::new( let mut profile = GitProfile::new(
profile_name.clone(), profile_name.clone(),
user_name, user_name,
@@ -220,9 +208,9 @@ impl InitCommand {
manager.add_profile(profile_name.clone(), profile)?; manager.add_profile(profile_name.clone(), profile)?;
manager.set_default_profile(Some(profile_name))?; manager.set_default_profile(Some(profile_name))?;
// LLM provider selection
println!("\n{}", messages.select_llm_provider().bold()); println!("\n{}", messages.select_llm_provider().bold());
let providers = vec![
let provider_display_names = vec![
"Ollama (local)", "Ollama (local)",
"OpenAI", "OpenAI",
"Anthropic Claude", "Anthropic Claude",
@@ -230,49 +218,90 @@ impl InitCommand {
"DeepSeek", "DeepSeek",
"OpenRouter" "OpenRouter"
]; ];
let provider_idx = Select::new() let provider_idx = Select::new()
.items(&providers) .items(&provider_display_names)
.default(0) .default(0)
.interact()?; .interact()?;
let provider = match provider_idx { let providers = get_supported_providers();
0 => "ollama", let provider = providers[provider_idx].to_string();
1 => "openai",
2 => "anthropic", let keyring = manager.keyring();
3 => "kimi", let keyring_available = keyring.is_available();
4 => "deepseek",
5 => "openrouter", if !keyring_available {
_ => "ollama", println!("\n{}", "⚠ Keyring is not available on this system.".yellow());
println!("{}", keyring.get_status_message().yellow());
}
let api_key = if provider_needs_api_key(&provider) {
let env_key = std::env::var("QUICOMMIT_API_KEY")
.or_else(|_| std::env::var(format!("QUICOMMIT_{}_API_KEY", provider.to_uppercase())))
.ok();
if let Some(key) = env_key {
println!("\n{} {}", "".green(), "Found API key in environment variable.".green());
None
} else if keyring_available {
let prompt = match provider.as_str() {
"openai" => messages.openai_api_key(),
"anthropic" => messages.anthropic_api_key(),
"kimi" => messages.kimi_api_key(),
"deepseek" => messages.deepseek_api_key(),
"openrouter" => messages.openrouter_api_key(),
_ => "API Key",
};
let key: String = Input::new()
.with_prompt(prompt)
.interact_text()?;
Some(key)
} else {
println!("\n{}", "Please set the QUICOMMIT_API_KEY environment variable.".yellow());
None
}
} else {
None
}; };
manager.set_llm_provider(provider.to_string()); let default_model = get_default_model(&provider);
let model: String = Input::new()
.with_prompt("Model name")
.default(default_model.to_string())
.interact_text()?;
// Configure API key if needed let base_url: Option<String> = if provider == "ollama" {
if provider == "openai" { let url: String = Input::new()
let api_key: String = Input::new() .with_prompt("Ollama server URL")
.with_prompt(messages.openai_api_key()) .default("http://localhost:11434".to_string())
.interact_text()?; .interact_text()?;
manager.set_openai_api_key(api_key); Some(url)
} else if provider == "anthropic" { } else {
let api_key: String = Input::new() let use_custom_url = Confirm::new()
.with_prompt(messages.anthropic_api_key()) .with_prompt("Use custom API base URL?")
.interact_text()?; .default(false)
manager.set_anthropic_api_key(api_key); .interact()?;
} else if provider == "kimi" {
let api_key: String = Input::new() if use_custom_url {
.with_prompt(messages.kimi_api_key()) let url: String = Input::new()
.interact_text()?; .with_prompt("Base URL")
manager.set_kimi_api_key(api_key); .interact_text()?;
} else if provider == "deepseek" { Some(url)
let api_key: String = Input::new() } else {
.with_prompt(messages.deepseek_api_key()) None
.interact_text()?; }
manager.set_deepseek_api_key(api_key); };
} else if provider == "openrouter" {
let api_key: String = Input::new() manager.set_llm_provider(provider.clone());
.with_prompt(messages.openrouter_api_key()) manager.set_llm_model(model);
.interact_text()?; manager.set_llm_base_url(base_url);
manager.set_openrouter_api_key(api_key);
if let Some(key) = api_key {
if provider_needs_api_key(&provider) {
manager.set_api_key(&key)?;
println!("\n{} {}", "".green(), "API key stored securely in system keyring.".green());
}
} }
Ok(()) Ok(())

View File

@@ -270,10 +270,8 @@ impl TagCommand {
async fn generate_tag_message(&self, repo: &GitRepo, version: &str, messages: &Messages) -> Result<String> { async fn generate_tag_message(&self, repo: &GitRepo, version: &str, messages: &Messages) -> Result<String> {
let manager = ConfigManager::new()?; let manager = ConfigManager::new()?;
let config = manager.config();
let language = manager.get_language().unwrap_or(Language::English); let language = manager.get_language().unwrap_or(Language::English);
// Get commits since last tag
let tags = repo.get_tags()?; let tags = repo.get_tags()?;
let commits = if let Some(latest_tag) = tags.first() { let commits = if let Some(latest_tag) = tags.first() {
repo.get_commits_between(&latest_tag.name, "HEAD")? repo.get_commits_between(&latest_tag.name, "HEAD")?
@@ -287,7 +285,7 @@ impl TagCommand {
println!("{}", messages.ai_generating_tag(commits.len())); println!("{}", messages.ai_generating_tag(commits.len()));
let generator = ContentGenerator::new(&config.llm).await?; let generator = ContentGenerator::new(&manager).await?;
generator.generate_tag_message(version, &commits, language).await generator.generate_tag_message(version, &commits, language).await
} }

View File

@@ -1,4 +1,5 @@
use super::{AppConfig, GitProfile, TokenConfig}; use super::{AppConfig, GitProfile, TokenConfig};
use crate::utils::keyring::{KeyringManager, get_default_base_url, get_default_model, provider_needs_api_key};
use anyhow::{bail, Context, Result}; use anyhow::{bail, Context, Result};
use std::collections::HashMap; use std::collections::HashMap;
use std::path::{Path, PathBuf}; use std::path::{Path, PathBuf};
@@ -8,6 +9,7 @@ pub struct ConfigManager {
config: AppConfig, config: AppConfig,
config_path: PathBuf, config_path: PathBuf,
modified: bool, modified: bool,
keyring: KeyringManager,
} }
impl ConfigManager { impl ConfigManager {
@@ -28,6 +30,7 @@ impl ConfigManager {
config, config,
config_path: path.to_path_buf(), config_path: path.to_path_buf(),
modified: false, modified: false,
keyring: KeyringManager::new(),
}) })
} }
@@ -37,6 +40,7 @@ impl ConfigManager {
config: AppConfig::default(), config: AppConfig::default(),
config_path: path.to_path_buf(), config_path: path.to_path_buf(),
modified: true, modified: true,
keyring: KeyringManager::new(),
}) })
} }
@@ -262,96 +266,140 @@ impl ConfigManager {
/// Set LLM provider /// Set LLM provider
pub fn set_llm_provider(&mut self, provider: String) { pub fn set_llm_provider(&mut self, provider: String) {
self.config.llm.provider = provider; let default_model = get_default_model(&provider);
self.config.llm.provider = provider.clone();
if self.config.llm.model.is_empty() || self.config.llm.model == "llama2" {
self.config.llm.model = default_model.to_string();
}
self.modified = true; self.modified = true;
} }
/// Get OpenAI API key /// Get model
pub fn openai_api_key(&self) -> Option<&String> { pub fn llm_model(&self) -> &str {
self.config.llm.openai.api_key.as_ref() &self.config.llm.model
} }
/// Set OpenAI API key /// Set model
pub fn set_openai_api_key(&mut self, key: String) { pub fn set_llm_model(&mut self, model: String) {
self.config.llm.openai.api_key = Some(key); self.config.llm.model = model;
self.modified = true; self.modified = true;
} }
/// Get Anthropic API key /// Get base URL (returns provider default if not set)
pub fn anthropic_api_key(&self) -> Option<&String> { pub fn llm_base_url(&self) -> String {
self.config.llm.anthropic.api_key.as_ref() match &self.config.llm.base_url {
Some(url) => url.clone(),
None => get_default_base_url(&self.config.llm.provider).to_string(),
}
} }
/// Set Anthropic API key /// Set base URL
pub fn set_anthropic_api_key(&mut self, key: String) { pub fn set_llm_base_url(&mut self, url: Option<String>) {
self.config.llm.anthropic.api_key = Some(key); self.config.llm.base_url = url;
self.modified = true; self.modified = true;
} }
/// Get Kimi API key /// Get API key from configured storage method
pub fn kimi_api_key(&self) -> Option<&String> { pub fn get_api_key(&self) -> Option<String> {
self.config.llm.kimi.api_key.as_ref() // First try environment variables (always checked)
if let Some(key) = self.keyring.get_api_key(&self.config.llm.provider).unwrap_or(None) {
return Some(key);
}
// Then try config file if configured
if self.config.llm.api_key_storage == "config" {
return self.config.llm.api_key.clone();
}
None
} }
/// Set Kimi API key /// Store API key in configured storage method
pub fn set_kimi_api_key(&mut self, key: String) { pub fn set_api_key(&self, api_key: &str) -> Result<()> {
self.config.llm.kimi.api_key = Some(key); match self.config.llm.api_key_storage.as_str() {
self.modified = true; "keyring" => {
if !self.keyring.is_available() {
bail!("Keyring is not available. Set QUICOMMIT_API_KEY environment variable instead or change api_key_storage to 'config'.");
}
self.keyring.store_api_key(&self.config.llm.provider, api_key)
},
"config" => {
// We can't modify self.config here since self is immutable
// This will be handled by the caller updating the config
Ok(())
},
"environment" => {
bail!("API key storage set to 'environment'. Please set QUICOMMIT_{}_API_KEY environment variable.", self.config.llm.provider.to_uppercase());
},
_ => {
bail!("Invalid API key storage method: {}", self.config.llm.api_key_storage);
}
}
} }
/// Get Kimi base URL /// Delete API key from configured storage method
pub fn kimi_base_url(&self) -> &str { pub fn delete_api_key(&self) -> Result<()> {
&self.config.llm.kimi.base_url match self.config.llm.api_key_storage.as_str() {
"keyring" => {
if self.keyring.is_available() {
self.keyring.delete_api_key(&self.config.llm.provider)?;
}
},
"config" => {
// We can't modify self.config here since self is immutable
// This will be handled by the caller updating the config
},
"environment" => {
// Environment variables are not managed by the app
},
_ => {
bail!("Invalid API key storage method: {}", self.config.llm.api_key_storage);
}
}
Ok(())
} }
/// Set Kimi base URL /// Check if API key is configured
pub fn set_kimi_base_url(&mut self, url: String) { pub fn has_api_key(&self) -> bool {
self.config.llm.kimi.base_url = url; if !provider_needs_api_key(&self.config.llm.provider) {
self.modified = true; return true;
}
// Check environment variables
if self.keyring.get_api_key(&self.config.llm.provider).unwrap_or(None).is_some() {
return true;
}
// Check config file if configured
if self.config.llm.api_key_storage == "config" {
return self.config.llm.api_key.is_some();
}
false
} }
/// Get DeepSeek API key /// Get keyring manager reference
pub fn deepseek_api_key(&self) -> Option<&String> { pub fn keyring(&self) -> &KeyringManager {
self.config.llm.deepseek.api_key.as_ref() &self.keyring
} }
/// Set DeepSeek API key /// Configure LLM provider with all settings
pub fn set_deepseek_api_key(&mut self, key: String) { pub fn configure_llm(&mut self, provider: String, model: Option<String>, base_url: Option<String>, api_key: Option<&str>) -> Result<()> {
self.config.llm.deepseek.api_key = Some(key); self.set_llm_provider(provider.clone());
self.modified = true;
} if let Some(m) = model {
self.set_llm_model(m);
/// Get DeepSeek base URL }
pub fn deepseek_base_url(&self) -> &str {
&self.config.llm.deepseek.base_url self.set_llm_base_url(base_url);
}
if let Some(key) = api_key {
/// Set DeepSeek base URL if provider_needs_api_key(&provider) {
pub fn set_deepseek_base_url(&mut self, url: String) { self.set_api_key(key)?;
self.config.llm.deepseek.base_url = url; }
self.modified = true; }
}
Ok(())
/// Get OpenRouter API key
pub fn openrouter_api_key(&self) -> Option<&String> {
self.config.llm.openrouter.api_key.as_ref()
}
/// Set OpenRouter API key
pub fn set_openrouter_api_key(&mut self, key: String) {
self.config.llm.openrouter.api_key = Some(key);
self.modified = true;
}
/// Get OpenRouter base URL
pub fn openrouter_base_url(&self) -> &str {
&self.config.llm.openrouter.base_url
}
/// Set OpenRouter base URL
pub fn set_openrouter_base_url(&mut self, url: String) {
self.config.llm.openrouter.base_url = url;
self.modified = true;
} }
// Commit configuration // Commit configuration
@@ -471,6 +519,7 @@ impl Default for ConfigManager {
config: AppConfig::default(), config: AppConfig::default(),
config_path: PathBuf::new(), config_path: PathBuf::new(),
modified: false, modified: false,
keyring: KeyringManager::new(),
} }
} }
} }

View File

@@ -80,37 +80,16 @@ impl Default for AppConfig {
/// LLM configuration /// LLM configuration
#[derive(Debug, Clone, Serialize, Deserialize)] #[derive(Debug, Clone, Serialize, Deserialize)]
pub struct LlmConfig { pub struct LlmConfig {
/// Default LLM provider /// Current LLM provider (ollama, openai, anthropic, kimi, deepseek, openrouter)
#[serde(default = "default_llm_provider")] #[serde(default = "default_llm_provider")]
pub provider: String, pub provider: String,
/// OpenAI configuration /// Model to use (stored in config, not in keyring)
#[serde(default)] #[serde(default = "default_model")]
pub openai: OpenAiConfig, pub model: String,
/// Ollama configuration /// API base URL (optional, will use provider default if not set)
#[serde(default)] pub base_url: Option<String>,
pub ollama: OllamaConfig,
/// Anthropic Claude configuration
#[serde(default)]
pub anthropic: AnthropicConfig,
/// Kimi (Moonshot AI) configuration
#[serde(default)]
pub kimi: KimiConfig,
/// DeepSeek configuration
#[serde(default)]
pub deepseek: DeepSeekConfig,
/// OpenRouter configuration
#[serde(default)]
pub openrouter: OpenRouterConfig,
/// Custom API configuration
#[serde(default)]
pub custom: Option<CustomLlmConfig>,
/// Maximum tokens for generation /// Maximum tokens for generation
#[serde(default = "default_max_tokens")] #[serde(default = "default_max_tokens")]
@@ -123,186 +102,35 @@ pub struct LlmConfig {
/// Timeout in seconds /// Timeout in seconds
#[serde(default = "default_timeout")] #[serde(default = "default_timeout")]
pub timeout: u64, pub timeout: u64,
/// API key storage method (keyring, config, environment)
#[serde(default = "default_api_key_storage")]
pub api_key_storage: String,
/// API key (stored in config for fallback, encrypted if encrypt_sensitive is true)
#[serde(default)]
pub api_key: Option<String>,
}
fn default_api_key_storage() -> String {
"keyring".to_string()
} }
impl Default for LlmConfig { impl Default for LlmConfig {
fn default() -> Self { fn default() -> Self {
Self { Self {
provider: default_llm_provider(), provider: default_llm_provider(),
openai: OpenAiConfig::default(), model: default_model(),
ollama: OllamaConfig::default(), base_url: None,
anthropic: AnthropicConfig::default(),
kimi: KimiConfig::default(),
deepseek: DeepSeekConfig::default(),
openrouter: OpenRouterConfig::default(),
custom: None,
max_tokens: default_max_tokens(), max_tokens: default_max_tokens(),
temperature: default_temperature(), temperature: default_temperature(),
timeout: default_timeout(), timeout: default_timeout(),
} api_key_storage: default_api_key_storage(),
}
}
/// OpenAI API configuration
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct OpenAiConfig {
/// API key
pub api_key: Option<String>,
/// Model to use
#[serde(default = "default_openai_model")]
pub model: String,
/// API base URL (for custom endpoints)
#[serde(default = "default_openai_base_url")]
pub base_url: String,
}
impl Default for OpenAiConfig {
fn default() -> Self {
Self {
api_key: None, api_key: None,
model: default_openai_model(),
base_url: default_openai_base_url(),
} }
} }
} }
/// Ollama configuration
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct OllamaConfig {
/// Ollama server URL
#[serde(default = "default_ollama_url")]
pub url: String,
/// Model to use
#[serde(default = "default_ollama_model")]
pub model: String,
}
impl Default for OllamaConfig {
fn default() -> Self {
Self {
url: default_ollama_url(),
model: default_ollama_model(),
}
}
}
/// Anthropic Claude configuration
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct AnthropicConfig {
/// API key
pub api_key: Option<String>,
/// Model to use
#[serde(default = "default_anthropic_model")]
pub model: String,
}
impl Default for AnthropicConfig {
fn default() -> Self {
Self {
api_key: None,
model: default_anthropic_model(),
}
}
}
/// Kimi (Moonshot AI) configuration
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct KimiConfig {
/// API key
pub api_key: Option<String>,
/// Model to use
#[serde(default = "default_kimi_model")]
pub model: String,
/// API base URL (for custom endpoints)
#[serde(default = "default_kimi_base_url")]
pub base_url: String,
}
impl Default for KimiConfig {
fn default() -> Self {
Self {
api_key: None,
model: default_kimi_model(),
base_url: default_kimi_base_url(),
}
}
}
/// DeepSeek configuration
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct DeepSeekConfig {
/// API key
pub api_key: Option<String>,
/// Model to use
#[serde(default = "default_deepseek_model")]
pub model: String,
/// API base URL (for custom endpoints)
#[serde(default = "default_deepseek_base_url")]
pub base_url: String,
}
impl Default for DeepSeekConfig {
fn default() -> Self {
Self {
api_key: None,
model: default_deepseek_model(),
base_url: default_deepseek_base_url(),
}
}
}
/// OpenRouter configuration
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct OpenRouterConfig {
/// API key
pub api_key: Option<String>,
/// Model to use
#[serde(default = "default_openrouter_model")]
pub model: String,
/// API base URL (for custom endpoints)
#[serde(default = "default_openrouter_base_url")]
pub base_url: String,
}
impl Default for OpenRouterConfig {
fn default() -> Self {
Self {
api_key: None,
model: default_openrouter_model(),
base_url: default_openrouter_base_url(),
}
}
}
/// Custom LLM API configuration
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct CustomLlmConfig {
/// API endpoint URL
pub url: String,
/// API key (optional)
pub api_key: Option<String>,
/// Model name
pub model: String,
/// Request format template (JSON)
pub request_template: String,
/// Response path to extract content (e.g., "choices.0.message.content")
pub response_path: String,
}
/// Commit configuration /// Commit configuration
#[derive(Debug, Clone, Serialize, Deserialize)] #[derive(Debug, Clone, Serialize, Deserialize)]
pub struct CommitConfig { pub struct CommitConfig {
@@ -592,6 +420,10 @@ fn default_llm_provider() -> String {
"ollama".to_string() "ollama".to_string()
} }
fn default_model() -> String {
"llama2".to_string()
}
fn default_max_tokens() -> u32 { fn default_max_tokens() -> u32 {
500 500
} }
@@ -604,50 +436,6 @@ fn default_timeout() -> u64 {
30 30
} }
fn default_openai_model() -> String {
"gpt-4".to_string()
}
fn default_openai_base_url() -> String {
"https://api.openai.com/v1".to_string()
}
fn default_ollama_url() -> String {
"http://localhost:11434".to_string()
}
fn default_ollama_model() -> String {
"llama2".to_string()
}
fn default_anthropic_model() -> String {
"claude-3-sonnet-20240229".to_string()
}
fn default_kimi_model() -> String {
"moonshot-v1-8k".to_string()
}
fn default_kimi_base_url() -> String {
"https://api.moonshot.cn/v1".to_string()
}
fn default_deepseek_model() -> String {
"deepseek-chat".to_string()
}
fn default_deepseek_base_url() -> String {
"https://api.deepseek.com/v1".to_string()
}
fn default_openrouter_model() -> String {
"openai/gpt-3.5-turbo".to_string()
}
fn default_openrouter_base_url() -> String {
"https://openrouter.ai/api/v1".to_string()
}
fn default_commit_format() -> CommitFormat { fn default_commit_format() -> CommitFormat {
CommitFormat::Conventional CommitFormat::Conventional
} }

View File

@@ -1,4 +1,5 @@
use crate::config::{CommitFormat, LlmConfig, Language}; use crate::config::{CommitFormat, Language};
use crate::config::manager::ConfigManager;
use crate::git::{CommitInfo, GitRepo}; use crate::git::{CommitInfo, GitRepo};
use crate::llm::{GeneratedCommit, LlmClient}; use crate::llm::{GeneratedCommit, LlmClient};
use anyhow::{Context, Result}; use anyhow::{Context, Result};
@@ -10,12 +11,11 @@ pub struct ContentGenerator {
impl ContentGenerator { impl ContentGenerator {
/// Create new content generator /// Create new content generator
pub async fn new(config: &LlmConfig) -> Result<Self> { pub async fn new(manager: &ConfigManager) -> Result<Self> {
let llm_client = LlmClient::from_config(config).await?; let llm_client = LlmClient::from_config(manager).await?;
// Check if provider is available
if !llm_client.is_available().await { if !llm_client.is_available().await {
anyhow::bail!("LLM provider '{}' is not available", config.provider); anyhow::bail!("LLM provider '{}' is not available", manager.llm_provider());
} }
Ok(Self { llm_client }) Ok(Self { llm_client })

View File

@@ -57,48 +57,50 @@ impl Default for LlmClientConfig {
} }
impl LlmClient { impl LlmClient {
/// Create LLM client from configuration /// Create LLM client from configuration manager
pub async fn from_config(config: &crate::config::LlmConfig) -> Result<Self> { pub async fn from_config(manager: &crate::config::manager::ConfigManager) -> Result<Self> {
let config = manager.config();
let client_config = LlmClientConfig { let client_config = LlmClientConfig {
max_tokens: config.max_tokens, max_tokens: config.llm.max_tokens,
temperature: config.temperature, temperature: config.llm.temperature,
timeout: Duration::from_secs(config.timeout), timeout: Duration::from_secs(config.llm.timeout),
}; };
let provider: Box<dyn LlmProvider> = match config.provider.as_str() { let provider = config.llm.provider.as_str();
let model = config.llm.model.as_str();
let base_url = manager.llm_base_url();
let api_key = manager.get_api_key();
let provider: Box<dyn LlmProvider> = match provider {
"ollama" => { "ollama" => {
Box::new(OllamaClient::new(&config.ollama.url, &config.ollama.model)) Box::new(OllamaClient::new(&base_url, model))
} }
"openai" => { "openai" => {
let api_key = config.openai.api_key.as_ref() let key = api_key.as_ref()
.ok_or_else(|| anyhow::anyhow!("OpenAI API key not configured"))?; .ok_or_else(|| anyhow::anyhow!("OpenAI API key not configured"))?;
Box::new(OpenAiClient::new( Box::new(OpenAiClient::new(&base_url, key, model)?)
&config.openai.base_url,
api_key,
&config.openai.model,
)?)
} }
"anthropic" => { "anthropic" => {
let api_key = config.anthropic.api_key.as_ref() let key = api_key.as_ref()
.ok_or_else(|| anyhow::anyhow!("Anthropic API key not configured"))?; .ok_or_else(|| anyhow::anyhow!("Anthropic API key not configured"))?;
Box::new(AnthropicClient::new(api_key, &config.anthropic.model)?) Box::new(AnthropicClient::new(key, model)?)
} }
"kimi" => { "kimi" => {
let api_key = config.kimi.api_key.as_ref() let key = api_key.as_ref()
.ok_or_else(|| anyhow::anyhow!("Kimi API key not configured"))?; .ok_or_else(|| anyhow::anyhow!("Kimi API key not configured"))?;
Box::new(KimiClient::with_base_url(api_key, &config.kimi.model, &config.kimi.base_url)?) Box::new(KimiClient::with_base_url(key, model, &base_url)?)
} }
"deepseek" => { "deepseek" => {
let api_key = config.deepseek.api_key.as_ref() let key = api_key.as_ref()
.ok_or_else(|| anyhow::anyhow!("DeepSeek API key not configured"))?; .ok_or_else(|| anyhow::anyhow!("DeepSeek API key not configured"))?;
Box::new(DeepSeekClient::with_base_url(api_key, &config.deepseek.model, &config.deepseek.base_url)?) Box::new(DeepSeekClient::with_base_url(key, model, &base_url)?)
} }
"openrouter" => { "openrouter" => {
let api_key = config.openrouter.api_key.as_ref() let key = api_key.as_ref()
.ok_or_else(|| anyhow::anyhow!("OpenRouter API key not configured"))?; .ok_or_else(|| anyhow::anyhow!("OpenRouter API key not configured"))?;
Box::new(OpenRouterClient::with_base_url(api_key, &config.openrouter.model, &config.openrouter.base_url)?) Box::new(OpenRouterClient::with_base_url(key, model, &base_url)?)
} }
_ => bail!("Unknown LLM provider: {}", config.provider), _ => bail!("Unknown LLM provider: {}", provider),
}; };
Ok(Self { Ok(Self {
@@ -1012,3 +1014,10 @@ Gruppieren Sie Commits nach:
Formatieren Sie in Markdown mit geeigneten Überschriften und Aufzählungspunkten. Formatieren Sie in Markdown mit geeigneten Überschriften und Aufzählungspunkten.
"#; "#;
/// Test LLM connection
pub async fn test_connection(manager: &crate::config::manager::ConfigManager) -> Result<String> {
let client = LlmClient::from_config(manager).await?;
let response = client.provider.generate("Say 'Hello, World!'").await?;
Ok(response)
}

219
src/utils/keyring.rs Normal file
View File

@@ -0,0 +1,219 @@
use anyhow::{bail, Context, Result};
use std::env;
const SERVICE_NAME: &str = "quicommit";
const ENV_API_KEY: &str = "QUICOMMIT_API_KEY";
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
pub enum KeyringStatus {
Available,
Unavailable,
}
pub struct KeyringManager {
status: KeyringStatus,
}
impl KeyringManager {
pub fn new() -> Self {
let status = Self::check_keyring_availability();
Self { status }
}
pub fn check_keyring_availability() -> KeyringStatus {
#[cfg(target_os = "windows")]
{
KeyringStatus::Available
}
#[cfg(target_os = "macos")]
{
KeyringStatus::Available
}
#[cfg(target_os = "linux")]
{
Self::check_linux_keyring()
}
#[cfg(not(any(target_os = "windows", target_os = "macos", target_os = "linux")))]
{
KeyringStatus::Unavailable
}
}
#[cfg(target_os = "linux")]
fn check_linux_keyring() -> KeyringStatus {
use std::path::Path;
let has_dbus = Path::new("/usr/bin/dbus-daemon").exists()
|| Path::new("/bin/dbus-daemon").exists()
|| env::var("DBUS_SESSION_BUS_ADDRESS").is_ok();
let has_keyring = Path::new("/usr/bin/gnome-keyring-daemon").exists()
|| Path::new("/usr/bin/gnome-keyring").exists()
|| Path::new("/usr/bin/kwalletd5").exists()
|| Path::new("/usr/bin/kwalletd6").exists()
|| env::var("SECRET_SERVICE").is_ok();
if has_dbus && has_keyring {
KeyringStatus::Available
} else {
KeyringStatus::Unavailable
}
}
pub fn status(&self) -> KeyringStatus {
self.status
}
pub fn is_available(&self) -> bool {
self.status == KeyringStatus::Available
}
pub fn store_api_key(&self, provider: &str, api_key: &str) -> Result<()> {
if !self.is_available() {
bail!("Keyring is not available on this system");
}
let entry = keyring::Entry::new(SERVICE_NAME, provider)
.context("Failed to create keyring entry")?;
entry.set_password(api_key)
.context("Failed to store API key")?;
Ok(())
}
pub fn get_api_key(&self, provider: &str) -> Result<Option<String>> {
// 优先从环境变量获取
if let Ok(key) = env::var(ENV_API_KEY) {
if !key.is_empty() {
return Ok(Some(key));
}
}
// keyring 不可用时直接返回
if !self.is_available() {
return Ok(None);
}
// 从 keyring 获取
let entry = keyring::Entry::new(SERVICE_NAME, provider)
.context("Failed to create keyring entry")?;
match entry.get_password() {
Ok(key) => Ok(Some(key)),
Err(keyring::Error::NoEntry) => Ok(None),
Err(e) => Err(e.into()),
}
}
pub fn delete_api_key(&self, provider: &str) -> Result<()> {
if !self.is_available() {
bail!("Keyring is not available on this system");
}
let entry = keyring::Entry::new(SERVICE_NAME, provider)
.context("Failed to create keyring entry")?;
entry.delete_credential()
.context("Failed to delete API key")?;
Ok(())
}
pub fn has_api_key(&self, provider: &str) -> bool {
self.get_api_key(provider).unwrap_or(None).is_some()
}
pub fn get_status_message(&self) -> String {
match self.status {
KeyringStatus::Available => {
#[cfg(target_os = "windows")]
{
"Windows Credential Manager is available".to_string()
}
#[cfg(target_os = "macos")]
{
"macOS Keychain is available".to_string()
}
#[cfg(target_os = "linux")]
{
"Linux secret service is available".to_string()
}
#[cfg(not(any(target_os = "windows", target_os = "macos", target_os = "linux")))]
{
"Keyring is available".to_string()
}
}
KeyringStatus::Unavailable => {
"Keyring is not available. Set QUICOMMIT_API_KEY environment variable.".to_string()
}
}
}
}
impl Default for KeyringManager {
fn default() -> Self {
Self::new()
}
}
pub fn get_default_base_url(provider: &str) -> &'static str {
match provider {
"openai" => "https://api.openai.com/v1",
"anthropic" => "https://api.anthropic.com/v1",
"kimi" => "https://api.moonshot.cn/v1",
"deepseek" => "https://api.deepseek.com/v1",
"openrouter" => "https://openrouter.ai/api/v1",
"ollama" => "http://localhost:11434",
_ => "",
}
}
pub fn get_default_model(provider: &str) -> &'static str {
match provider {
"openai" => "gpt-4",
"anthropic" => "claude-3-sonnet-20240229",
"kimi" => "moonshot-v1-8k",
"deepseek" => "deepseek-chat",
"openrouter" => "openai/gpt-3.5-turbo",
"ollama" => "llama2",
_ => "",
}
}
pub fn get_supported_providers() -> &'static [&'static str] {
&["ollama", "openai", "anthropic", "kimi", "deepseek", "openrouter"]
}
pub fn provider_needs_api_key(provider: &str) -> bool {
provider != "ollama"
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn test_get_default_base_url() {
assert_eq!(get_default_base_url("openai"), "https://api.openai.com/v1");
assert_eq!(get_default_base_url("anthropic"), "https://api.anthropic.com/v1");
assert_eq!(get_default_base_url("kimi"), "https://api.moonshot.cn/v1");
assert_eq!(get_default_base_url("deepseek"), "https://api.deepseek.com/v1");
assert_eq!(get_default_base_url("openrouter"), "https://openrouter.ai/api/v1");
assert_eq!(get_default_base_url("ollama"), "http://localhost:11434");
}
#[test]
fn test_get_default_model() {
assert_eq!(get_default_model("openai"), "gpt-4");
assert_eq!(get_default_model("anthropic"), "claude-3-sonnet-20240229");
assert_eq!(get_default_model("ollama"), "llama2");
}
#[test]
fn test_provider_needs_api_key() {
assert!(provider_needs_api_key("openai"));
assert!(provider_needs_api_key("anthropic"));
assert!(!provider_needs_api_key("ollama"));
}
}

View File

@@ -1,6 +1,7 @@
pub mod crypto; pub mod crypto;
pub mod editor; pub mod editor;
pub mod formatter; pub mod formatter;
pub mod keyring;
pub mod validators; pub mod validators;
use anyhow::{Context, Result}; use anyhow::{Context, Result};

7
test-keyring/Cargo.toml Normal file
View File

@@ -0,0 +1,7 @@
[package]
name = "test-keyring"
version = "0.1.0"
edition = "2024"
[dependencies]
keyring = "3"

18
test-keyring/src/main.rs Normal file
View File

@@ -0,0 +1,18 @@
use keyring::Entry;
fn main() {
println!("Testing keyring functionality...");
// Test storing password
let entry = Entry::new("test-service", "test-user").unwrap();
println!("Created entry successfully");
entry.set_password("test-password").unwrap();
println!("Stored password successfully");
// Test retrieving password
let retrieved = entry.get_password().unwrap();
println!("Retrieved password: {}", retrieved);
println!("Keyring test completed successfully!");
}

18
test_keyring.rs Normal file
View File

@@ -0,0 +1,18 @@
use keyring::Entry;
fn main() {
println!("Testing keyring functionality...");
// Test storing password
let entry = Entry::new("test-service", "test-user").unwrap();
println!("Created entry successfully");
entry.set_password("test-password").unwrap();
println!("Stored password successfully");
// Test retrieving password
let retrieved = entry.get_password().unwrap();
println!("Retrieved password: {}", retrieved);
println!("Keyring test completed successfully!");
}

View File

@@ -47,6 +47,24 @@ fn create_commit(dir: &PathBuf, message: &str) {
.expect("Failed to create commit"); .expect("Failed to create commit");
} }
fn setup_git_repo(dir: &PathBuf) {
create_git_repo(dir);
configure_git_user(dir);
}
fn setup_test_repo_with_file(dir: &PathBuf, file_name: &str, file_content: &str) {
setup_git_repo(dir);
create_test_file(dir, file_name, file_content);
stage_file(dir, file_name);
}
fn init_quicommit(dir: &PathBuf, config_path: &PathBuf) {
let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["init", "--yes", "--config", config_path.to_str().unwrap()])
.current_dir(dir);
cmd.assert().success();
}
mod cli_basic { mod cli_basic {
use super::*; use super::*;
@@ -57,7 +75,10 @@ mod cli_basic {
cmd.assert() cmd.assert()
.success() .success()
.stdout(predicate::str::contains("QuiCommit")) .stdout(predicate::str::contains("QuiCommit"))
.stdout(predicate::str::contains("AI-powered Git assistant")); .stdout(predicate::str::contains("AI-powered Git assistant"))
.stdout(predicate::str::contains("Usage:"))
.stdout(predicate::str::contains("Commands:"))
.stdout(predicate::str::contains("Options:"));
} }
#[test] #[test]
@@ -252,15 +273,10 @@ mod commit_command {
fn test_commit_no_changes() { fn test_commit_no_changes() {
let temp_dir = TempDir::new().unwrap(); let temp_dir = TempDir::new().unwrap();
let repo_path = temp_dir.path().to_path_buf(); let repo_path = temp_dir.path().to_path_buf();
create_git_repo(&repo_path); setup_git_repo(&repo_path);
configure_git_user(&repo_path);
let config_path = repo_path.join("config.toml"); let config_path = repo_path.join("config.toml");
init_quicommit(&repo_path, &config_path);
let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["init", "--yes", "--config", config_path.to_str().unwrap()])
.current_dir(&repo_path);
cmd.assert().success();
let mut cmd = Command::cargo_bin("quicommit").unwrap(); let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["commit", "--manual", "-m", "test: empty", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()]) cmd.args(&["commit", "--manual", "-m", "test: empty", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()])
@@ -275,18 +291,10 @@ mod commit_command {
fn test_commit_with_staged_changes() { fn test_commit_with_staged_changes() {
let temp_dir = TempDir::new().unwrap(); let temp_dir = TempDir::new().unwrap();
let repo_path = temp_dir.path().to_path_buf(); let repo_path = temp_dir.path().to_path_buf();
create_git_repo(&repo_path); setup_test_repo_with_file(&repo_path, "test.txt", "Hello, World!");
configure_git_user(&repo_path);
create_test_file(&repo_path, "test.txt", "Hello, World!");
stage_file(&repo_path, "test.txt");
let config_path = repo_path.join("config.toml"); let config_path = repo_path.join("config.toml");
init_quicommit(&repo_path, &config_path);
let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["init", "--yes", "--config", config_path.to_str().unwrap()])
.current_dir(&repo_path);
cmd.assert().success();
let mut cmd = Command::cargo_bin("quicommit").unwrap(); let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["commit", "--manual", "-m", "test: add test file", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()]) cmd.args(&["commit", "--manual", "-m", "test: add test file", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()])
@@ -301,18 +309,10 @@ mod commit_command {
fn test_commit_date_mode() { fn test_commit_date_mode() {
let temp_dir = TempDir::new().unwrap(); let temp_dir = TempDir::new().unwrap();
let repo_path = temp_dir.path().to_path_buf(); let repo_path = temp_dir.path().to_path_buf();
create_git_repo(&repo_path); setup_test_repo_with_file(&repo_path, "daily.txt", "Daily update");
configure_git_user(&repo_path);
create_test_file(&repo_path, "daily.txt", "Daily update");
stage_file(&repo_path, "daily.txt");
let config_path = repo_path.join("config.toml"); let config_path = repo_path.join("config.toml");
init_quicommit(&repo_path, &config_path);
let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["init", "--yes", "--config", config_path.to_str().unwrap()])
.current_dir(&repo_path);
cmd.assert().success();
let mut cmd = Command::cargo_bin("quicommit").unwrap(); let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["commit", "--date", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()]) cmd.args(&["commit", "--date", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()])
@@ -349,19 +349,14 @@ mod tag_command {
fn test_tag_list_empty() { fn test_tag_list_empty() {
let temp_dir = TempDir::new().unwrap(); let temp_dir = TempDir::new().unwrap();
let repo_path = temp_dir.path().to_path_buf(); let repo_path = temp_dir.path().to_path_buf();
create_git_repo(&repo_path); setup_git_repo(&repo_path);
configure_git_user(&repo_path);
create_test_file(&repo_path, "test.txt", "content"); create_test_file(&repo_path, "test.txt", "content");
stage_file(&repo_path, "test.txt"); stage_file(&repo_path, "test.txt");
create_commit(&repo_path, "feat: initial commit"); create_commit(&repo_path, "feat: initial commit");
let config_path = repo_path.join("config.toml"); let config_path = repo_path.join("config.toml");
init_quicommit(&repo_path, &config_path);
let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["init", "--yes", "--config", config_path.to_str().unwrap()])
.current_dir(&repo_path);
cmd.assert().success();
let mut cmd = Command::cargo_bin("quicommit").unwrap(); let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["tag", "--name", "v0.1.0", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()]) cmd.args(&["tag", "--name", "v0.1.0", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()])
@@ -380,16 +375,12 @@ mod changelog_command {
fn test_changelog_init() { fn test_changelog_init() {
let temp_dir = TempDir::new().unwrap(); let temp_dir = TempDir::new().unwrap();
let repo_path = temp_dir.path().to_path_buf(); let repo_path = temp_dir.path().to_path_buf();
create_git_repo(&repo_path); setup_git_repo(&repo_path);
configure_git_user(&repo_path);
let config_path = repo_path.join("config.toml"); let config_path = repo_path.join("config.toml");
let changelog_path = repo_path.join("CHANGELOG.md"); let changelog_path = repo_path.join("CHANGELOG.md");
let mut cmd = Command::cargo_bin("quicommit").unwrap(); init_quicommit(&repo_path, &config_path);
cmd.args(&["init", "--yes", "--config", config_path.to_str().unwrap()])
.current_dir(&repo_path);
cmd.assert().success();
let mut cmd = Command::cargo_bin("quicommit").unwrap(); let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["changelog", "--init", "--output", changelog_path.to_str().unwrap(), "--config", config_path.to_str().unwrap()]) cmd.args(&["changelog", "--init", "--output", changelog_path.to_str().unwrap(), "--config", config_path.to_str().unwrap()])
@@ -404,19 +395,14 @@ mod changelog_command {
fn test_changelog_dry_run() { fn test_changelog_dry_run() {
let temp_dir = TempDir::new().unwrap(); let temp_dir = TempDir::new().unwrap();
let repo_path = temp_dir.path().to_path_buf(); let repo_path = temp_dir.path().to_path_buf();
create_git_repo(&repo_path); setup_git_repo(&repo_path);
configure_git_user(&repo_path);
create_test_file(&repo_path, "test.txt", "content"); create_test_file(&repo_path, "test.txt", "content");
stage_file(&repo_path, "test.txt"); stage_file(&repo_path, "test.txt");
create_commit(&repo_path, "feat: add feature"); create_commit(&repo_path, "feat: add feature");
let config_path = repo_path.join("config.toml"); let config_path = repo_path.join("config.toml");
init_quicommit(&repo_path, &config_path);
let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["init", "--yes", "--config", config_path.to_str().unwrap()])
.current_dir(&repo_path);
cmd.assert().success();
let mut cmd = Command::cargo_bin("quicommit").unwrap(); let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["changelog", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()]) cmd.args(&["changelog", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()])
@@ -532,18 +518,10 @@ mod validators {
fn test_commit_message_validation() { fn test_commit_message_validation() {
let temp_dir = TempDir::new().unwrap(); let temp_dir = TempDir::new().unwrap();
let repo_path = temp_dir.path().to_path_buf(); let repo_path = temp_dir.path().to_path_buf();
create_git_repo(&repo_path); setup_test_repo_with_file(&repo_path, "test.txt", "content");
configure_git_user(&repo_path);
create_test_file(&repo_path, "test.txt", "content");
stage_file(&repo_path, "test.txt");
let config_path = repo_path.join("config.toml"); let config_path = repo_path.join("config.toml");
init_quicommit(&repo_path, &config_path);
let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["init", "--yes", "--config", config_path.to_str().unwrap()])
.current_dir(&repo_path);
cmd.assert().success();
let mut cmd = Command::cargo_bin("quicommit").unwrap(); let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["commit", "--manual", "-m", "invalid commit message without type", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()]) cmd.args(&["commit", "--manual", "-m", "invalid commit message without type", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()])
@@ -558,18 +536,10 @@ mod validators {
fn test_valid_conventional_commit() { fn test_valid_conventional_commit() {
let temp_dir = TempDir::new().unwrap(); let temp_dir = TempDir::new().unwrap();
let repo_path = temp_dir.path().to_path_buf(); let repo_path = temp_dir.path().to_path_buf();
create_git_repo(&repo_path); setup_test_repo_with_file(&repo_path, "test.txt", "content");
configure_git_user(&repo_path);
create_test_file(&repo_path, "test.txt", "content");
stage_file(&repo_path, "test.txt");
let config_path = repo_path.join("config.toml"); let config_path = repo_path.join("config.toml");
init_quicommit(&repo_path, &config_path);
let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["init", "--yes", "--config", config_path.to_str().unwrap()])
.current_dir(&repo_path);
cmd.assert().success();
let mut cmd = Command::cargo_bin("quicommit").unwrap(); let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["commit", "--manual", "-m", "feat: add new feature", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()]) cmd.args(&["commit", "--manual", "-m", "feat: add new feature", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()])
@@ -588,18 +558,10 @@ mod subcommands {
fn test_commit_alias() { fn test_commit_alias() {
let temp_dir = TempDir::new().unwrap(); let temp_dir = TempDir::new().unwrap();
let repo_path = temp_dir.path().to_path_buf(); let repo_path = temp_dir.path().to_path_buf();
create_git_repo(&repo_path); setup_test_repo_with_file(&repo_path, "test.txt", "content");
configure_git_user(&repo_path);
create_test_file(&repo_path, "test.txt", "content");
stage_file(&repo_path, "test.txt");
let config_path = repo_path.join("config.toml"); let config_path = repo_path.join("config.toml");
init_quicommit(&repo_path, &config_path);
let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["init", "--yes", "--config", config_path.to_str().unwrap()])
.current_dir(&repo_path);
cmd.assert().success();
let mut cmd = Command::cargo_bin("quicommit").unwrap(); let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["c", "--manual", "-m", "fix: test", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()]) cmd.args(&["c", "--manual", "-m", "fix: test", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()])
@@ -640,3 +602,59 @@ mod subcommands {
.stdout(predicate::str::contains("default")); .stdout(predicate::str::contains("default"));
} }
} }
mod edge_cases {
use super::*;
#[test]
fn test_config_file_not_found() {
let temp_dir = TempDir::new().unwrap();
let non_existent_config = temp_dir.path().join("non_existent_config.toml");
let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["config", "show", "--config", non_existent_config.to_str().unwrap()]);
cmd.assert()
.success()
.stdout(predicate::str::contains("QuiCommit Configuration"))
.stdout(predicate::str::contains("Default profile: (none)"))
.stdout(predicate::str::contains("Profiles: 0"));
}
#[test]
fn test_invalid_git_repo() {
let temp_dir = TempDir::new().unwrap();
let repo_path = temp_dir.path().to_path_buf();
let config_path = repo_path.join("config.toml");
let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["init", "--yes", "--config", config_path.to_str().unwrap()]);
cmd.assert().success();
let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["commit", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()])
.current_dir(&repo_path);
cmd.assert()
.failure()
.stderr(predicate::str::contains("git").or(predicate::str::contains("repository")));
}
#[test]
fn test_empty_commit_message() {
let temp_dir = TempDir::new().unwrap();
let repo_path = temp_dir.path().to_path_buf();
setup_test_repo_with_file(&repo_path, "test.txt", "content");
let config_path = repo_path.join("config.toml");
init_quicommit(&repo_path, &config_path);
let mut cmd = Command::cargo_bin("quicommit").unwrap();
cmd.args(&["commit", "--manual", "-m", "", "--dry-run", "--yes", "--config", config_path.to_str().unwrap()])
.current_dir(&repo_path);
cmd.assert()
.failure()
.stderr(predicate::str::contains("Invalid conventional commit format"));
}
}